Vanish Skript

[ChunkerDunkers]

I have made a vanish Skript where on your actionbar, it has a message saying that you are vanished.

command /vanish:
	aliases: /v
	permission: Staff.vanish
	trigger:
		if {v.%player%} is true:
			set {v.%player%} to false
			set {vanish::%player%} to false
			reveal player to all players
			message "&8[&3Staff&8] &aVanish is now disabled"
			broadcast "&8[&a+&8] &7%player%"
		else:
			set {v.%player%} to true
			set {vanish::%player%} to true
			hide player from all players
			message "&8[&3Staff&8] &aVanish is now enabled."
			broadcast "&8[&4-&8] &7%player%"
			
every 1 seconds:
    loop all players:
        if {vanish::%loop-player%} is true:
            send action bar from "&a&lYou are in Vanish" to loop-player
		
every 30 seconds:
	loop all players:
		if {vanish::%loop-player%} is true:
			send "&8[&3Staff&8] &aPlease note you are vanished" to loop-player
		
on quit:
    delete {vanish::%player%}

 

[_Tarna_]

Nice!

But why do you set to vanish variables and only use one of them? You should delete the {v.%player%} variable since two are not needed and you could just use one. Also instead of looping all players for the action bar and the other message, you could just use a while loop, if you know what that is. And in the action bar expression, you put send action bar from. There is no from in that expression. It is just send action bar " " to loop-player. Another thing is that in your skript, the player gets hidden from all players including other staff and maybe even other vanished players. You can do hide player from all players where [input does not have permission "staff.vanish"] and it will hide them from everyone on the server who does not have that permission node. 

Just some things to note but the skript should work anyways after changing the action bar thing.