What is wrong with this skript?

[B00B5]

command /toggleitems:
	description: Toggle Random Items To The Sender!
	cooldown: 30 seconds
	cooldown message: &cYou Need To Wait &4&l%remaining time% &cTo Use This Command Again!
	cooldown bypass: toggleitems.nocooldown

	trigger:
		toggle {%player%.randomitems::*}


if {%player%.randomitems::*} is true:
	trigger:
		every 10 seconds:
			loop all players:
				if loop-player doesn't have space for any items:
					send "&cYou Don't Have Any Inventory Space Left For Random Items!" to player
				else:
					add 1 of (random item out of all items) to inventory of all players

There is 1 error.

How should I fix this?
 

[CoolProgrammer]

Hey there.

1. You have an if condition which is not fired by anything, meaning it doesn't make sense. It should be in something, such as event, command, loop, etc.

2. You have a timed loop inside of a condition, which again doesn't make sense.

3. You seem to be struggling a lot with this. From what I see, you are trying to make a skript which gives player random items.

 

Check this:

# This is the command to toggle random items.
command /toggleitems:
    trigger:
        # This if condition will check if random items is enabled for the player.
        # If it's not, then the player will be added to the variable.
        if {randomitems::*} contains player:
            # Remove player if the player is already in the variable.
            remove player's uuid from {randomitems::*}
            # A message to notify.
            send "You'll no longer recieve random items."
            stop
        # Add player to the variable of random items.
        add player's uuid to {randomitems::*}
        # A message to notify
        send "You'll now recieve random items."

# This is the 10 seconds loop where it will check and give players random items.
every 10 seconds:
    # Looping all the players in that variable
    loop {randomitems::*}:
        # Set {_p} as temp variable to get the player
        set {_p} to loop-value parsed as offline player
        # Check if player is online, and then give them a random item if they are.
        if {_p} is online:
            give {_p} random element out of all items

I've tried my best to break down each part of the code. Feel free to ask any other problem you face/don't understand.

 

Note to the ones who think I spoon-fed them

Sometimes, spoon-feeding is the only way a person could learn, especially with something like Skript, where there is not much information available on doing things.

Edited February 2, 2021 by CoolProgrammer