Help me with this skript!

[Ezekia]

Problem:

I'm not a brilliant skripter, so most of this code was guessing.. I'm trying to make a UHC server that is skripted, so if you could help it would be amazing for me!

Code:

# Setting Scoreboard values
when player is teleported to world "ul_uhclobby":
  set %scoreboard% to 1

when player is teleported to world "uhcworld":
  set %scoreboard% to 2

when player's gamemode switches to spectator:
  set %scoreboard% to 3

# Scoreboards (Value is 1 (Waiting), 2 (In-game) and 3 (spectating)
when %scoreboard% = 1:
  trigger:
    delete all other scoreboards
    create scoreboard with title "&eSpazz &bUHC"
    set line 1 to "&bOnline:"
    set line 2 to "&f%number_of_online_players%"
    set line 3 to ""
    set line 4 to "&bRight Now:"
    set line 5 to "&fWaiting"
when %scoreboard% = 2:
  trigger:
    delete all other scoreboards
    create scoreboard with title "&eSpazz &bUHC"
    set line 1 to "&bOnline:"
    set line 2 to "&f%number_of_online_players%"
    set line 3 to ""
    set line 4 to "&bRight Now:"
    set line 5 to "&fIn-game"
when %scoreboard% = 3:
  trigger:
    delete all other scoreboards
    create scoreboard with title "&eSpazz &bUHC"
    set line 1 to "&bOnline:"
    set line 2 to "&f%number_of_online_players%"
    set line 3 to ""
    set line 4 to "&bRight Now:"
    set line 5 to "&fSpectating"

# Starting the game
when %number_of_online_players% > 4 and %match_in_progress% = 0:
  trigger:
    generate new world named "uhcworld"
    send "&b[Spazz UHC] &fNew match is starting in 15 seconds..." to all players
    wait 5 seconds
    send "&b[Spazz UHC] &fNew match is starting in 10 seconds..." to all players
    wait 5 seconds
    send "&b[Spazz UHC] &fNew match is starting in 5 seconds..." to all players
    wait 1 second
    send "&b[Spazz UHC] &fNew match is starting in 4 seconds..." to all players
    wait 1 second
    send "&b[Spazz UHC] &fNew match is starting in 3 seconds..." to all players
    wait 1 second
    send "&b[Spazz UHC] &fNew match is starting in 2 seconds..." to all players
    wait 1 second
    send "&b[Spazz UHC] &fNew match is starting in 1 second..." to all players
    wait 1 second
    send "&b[Spazz UHC] &fNew match is starting!" to all players
    teleport all players to random position inside world border in world "uhcworld"
    send "&b[Spazz UHC] &fMatch has started!" to all players
    give 1 wooden sword to all players
    give 1 wooden pickaxe to all players
    give 1 wooden axe to all players
    send "&b[Spazz UHC] &fRun the command /recipes to see all new custom recipes!"

# The recipes command
command /recipes:
  send "&b[Spazz UHC] &fCustom crafting is coming soon!" to player

# Shrinking the world border
when &number_of_online_players% > 4 and &match_in_progress& = 0:
  trigger:
    wait 615 seconds
    send "&b[Spazz UHC] &fWorld Border is now SHRINKING!" to all players
    make console run command "/worldborder set 250 300" in world "uhcworld"

# Spectate after death
when player dies in world "uhcworld":
  set player's gamemode to spectator
  send "&b[Spazz UHC] &fDo /uhclobby to go back to spawn or keep watching!"

# Winning
when 1 player in survival mode is left in world "uhcworld":
send "&b[Spazz UHC] &f%player% is the winner!
    
# Basic UHC Skript made by Ezekia for SpazzUHC. Do NOT copy!

    

Anything else:

I have forgotten a few things. If you could add them I would love it!

[Ezekia]

Just now, Ezekia said:

I have forgotten a few things.

For example, there is no code to delete the UHC world once the round is finished.

[Nd_]

1: I would recommend using ID based scores instead of clearing the score and writing it again, it's a bit more complicated, but it has the plus side of not making the scoreboard look like it is flickering

2: when isn't something that skript uses, it's on or nothing

3: You need variables, as putting it in %% is only for skript defined variables

4: There is no event from my knowledge to check if a variable changes, however, you can check if a variable is something, so you could use a while event.

5: you need trigger:(indent next line) for a command

6: No offence, but there are a bunch of invalid events

[Ezekia]

18 minutes ago, Nd_ said:

1: I would recommend using ID based scores instead of clearing the score and writing it again, it's a bit more complicated, but it has the plus side of not making the scoreboard look like it is flickering

2: when isn't something that skript uses, it's on or nothing

3: You need variables, as putting it in %% is only for skript defined variables

4: There is no event from my knowledge to check if a variable changes, however, you can check if a variable is something, so you could use a while event.

5: you need trigger:(indent next line) for a command

6: No offence, but there are a bunch of invalid events

6 is fine cuz as i said im a complete nub at skript and most of it was being made up lol

if you could help with variables and stuff that would be g r e a t

5: k i'll ad trigger

4 & 2: help meh

3:how do i variable lol

1: again.. how?

im updating the skript soon as well so be prepared for more bad skripting

[Ezekia]

NEED HELP STILL!

[Ezekia]

On 11/17/2019 at 6:18 PM, Nd_ said:

1: I would recommend using ID based scores instead of clearing the score and writing it again, it's a bit more complicated, but it has the plus side of not making the scoreboard look like it is flickering

2: when isn't something that skript uses, it's on or nothing

3: You need variables, as putting it in %% is only for skript defined variables

4: There is no event from my knowledge to check if a variable changes, however, you can check if a variable is something, so you could use a while event.

5: you need trigger:(indent next line) for a command

6: No offence, but there are a bunch of invalid events

ik it sounds like im being lazy, but can you just do it for me? I have no idea what ur saying

Im an expirienced coder, so ik most things but how in skript??! Im gonna update soon so you could work with that

[Nd_]

2 hours ago, Ezekia said:

ik it sounds like im being lazy, but can you just do it for me? I have no idea what ur saying

Im an expirienced coder, so ik most things but how in skript??! Im gonna update soon so you could work with that

I can try, but I'm lazy, and might be a bit busy, though I will try

[TheRustySpud]

5 hours ago, Ezekia said:

ik it sounds like im being lazy, but can you just do it for me? I have no idea what ur saying

Im an expirienced coder, so ik most things but how in skript??! Im gonna update soon so you could work with that

I remade some of your things, keep in mind the scoreboard part is NOT included in my new skript. You're going to need to remake that yourself.
Remade version of skript (Pastebin)

I have also marked some spots in your code with #(Error here) in spots you might want to change up.

[Ezekia]

3 hours ago, TheRustySpud said:

I remade some of your things, keep in mind the scoreboard part is NOT included in my new skript. You're going to need to remake that yourself.
Remade version of skript (Pastebin)

I have also marked some spots in your code with #(Error here) in spots you might want to change up.

Yaaaassssss thanks! With the errors you said about, was the V meant to be a down arrow or something else?

[Ezekia]

6 hours ago, Nd_ said:

I can try, but I'm lazy, and might be a bit busy, though I will try

Thanks! If you could do the scoreboard and such that would be g r e a t.

If anyone wants to come test the Skript when I add it they can (but that wont be really soon)

Matches are every day and have cool things one i did yesterday:

everyone starts with a stack of xp bottles

everyone starts with a stack of lapis blocks

everyone starts with and enchant table

hastey boys is off

[Nd_]

8 hours ago, Ezekia said:

Thanks! If you could do the scoreboard and such that would be g r e a t.

If anyone wants to come test the Skript when I add it they can (but that wont be really soon)

Matches are every day and have cool things one i did yesterday:

everyone starts with a stack of xp bottles

everyone starts with a stack of lapis blocks

everyone starts with and enchant table

hastey boys is off

Should I make it so more than one round can be hosted at the same time?

[Ezekia]

3 hours ago, Nd_ said:

Should I make it so more than one round can be hosted at the same time?

Yes please! I think the rounds should be automatic

[Ezekia]

@Nd_ How far into it are you?

[Nd_]

Currently coding the UHC, need to code the wild and then I am done with the game(but not the other things)

Edited December 7, 2019 by Nd_

[Ezekia]

47 minutes ago, Nd_ said:

Currently coding the UHC, need to code the wild and then I am done with the game(but not the other things)

n o i c e

remember to do some things i havent done (like delting thw uhc world after each round)

the lobby should be in a different world, so it works a bit better

teleport inside border

 uuh

and someother stuff

kthx